Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import list exclusion edit missing on mobile #9736

Closed
2 tasks done
jt196 opened this issue Feb 5, 2024 · 5 comments
Closed
2 tasks done

Import list exclusion edit missing on mobile #9736

jt196 opened this issue Feb 5, 2024 · 5 comments
Labels
Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Status: Confirmed Stops stale bot from asking if stale Type: Bug Issue is a bug

Comments

@jt196
Copy link

jt196 commented Feb 5, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Current Behavior

Currently, on screens narrower than about 1000px, the year and spanner icon are missing from the import list exclusion list. They actually appear to be off screen rather than hidden, which makes me think this might not be intended behaviour.

Expected Behavior

Display the spanner on mobile devices. I'd have thought this was essential functionality for the list, the year less important.

I'm not sure if this is intended behaviour or not...

Solution would be to have a break for mobile devices.

<div class="ImportListExclusion-importExclusion-NU7R1">
    <div class="ImportListExclusion-tmdbId-H9u8c">597588</div>
    <div class="ImportListExclusion-movieTitle-TFFFF">Lucky Grandma</div>
    <div class="ImportListExclusion-movieYear-BWA8Y">2019</div>
    <div class="ImportListExclusion-actions-xNNGU"></div>
</div>

I had a little play with the CSS and this should work reasonably well, with titles disappearing behind the ellipsis if they exceed the space, year and spanner both visible:

// allow the content to determine the size
.ImportListExclusion-movieYear-BWA8Y,
.ImportListExclusion-actions-xNNGU {
    flex: 0 0 auto;
}

// Give the tmdb id a set size
.ImportListExclusion-tmdbId-H9u8c {
    flex: 0 0 50px;
}

// stretch and grow according to size
.ImportListExclusion-movieTitle-TFFFF {
    min-width: 0;
    -max width: 100%; // remove this
    flex: 1 0 0%; 
}

At the moment in the browser it looks like multiple elements have flex-basis set to 700px etc. This should allow the movie title to grow or shrink depending on the screen size. Hope this helps.

Steps To Reproduce

No response

Environment

- OS: Mobile
- Radarr: 5.3.5.8570

What branch are you running?

Master

Trace Logs? Not Optional

1000px + - visible

image

~990px moving off screen

image

960px gone

image

915px year is moving off screen

image

Trace Logs have been provided as applicable. Reports will be closed if the required logs are not provided.

  • I have read and followed the steps in the wiki link above and provided the required trace logs - the logs contain trace - that are relevant and show this issue.
@jt196 jt196 added Status: Needs Triage New Issue needing triage Type: Bug Issue is a bug labels Feb 5, 2024
@bakerboy448 bakerboy448 added Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Status: Confirmed Stops stale bot from asking if stale and removed Status: Needs Triage New Issue needing triage labels Feb 5, 2024
@jt196
Copy link
Author

jt196 commented Feb 6, 2024

Nice quick work folks!

Just a quick point, the amendments cause the year to be out somewhere towards the middle of the table if the screen width is wider than about 1000px:

image

If you're OK with that, then fine!

Another point, if you move the screen below 1000px, the year shifts off to the right. I think this is related to the fact that there's no table header div for the actions column, so it shifts as there's nothing there. I guess you can add a th div with the column header or empty space.

image

@mynameisbogdan
Copy link
Collaborator

It's expected.

@jt196
Copy link
Author

jt196 commented Feb 6, 2024

OK Bogdan, and the second point I assume isn't expected...

Good job anyway!

@mynameisbogdan
Copy link
Collaborator

Yes, second part too.

Feel free to open a PR if it annoys you that much. 😜

@jt196
Copy link
Author

jt196 commented Feb 6, 2024

Ha ok man!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: UI Issue is related to UI, should also add the issue to the new UI project, if it isn't a bug. Status: Confirmed Stops stale bot from asking if stale Type: Bug Issue is a bug
Projects
None yet
Development

No branches or pull requests

3 participants