Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sh fully echoes commands which error exit #382

Closed
MarkDBlackwell opened this issue Aug 11, 2022 · 2 comments
Closed

Sh fully echoes commands which error exit #382

MarkDBlackwell opened this issue Aug 11, 2022 · 2 comments

Comments

@MarkDBlackwell
Copy link
Contributor

As I recall, sometimes new users of this gem who experience an error are asked to report what's printed on their screen. Yet sometimes that output is insufficiently informative, because it's limited to 42 characters. Then they are asked to repeat their command while including a special flag on the command line. Sometimes they are reluctant to spend time to do so, and they move on, or just give up. This additional difficulty is, I suppose, a source of discouragement to new users.

For the benefit of this gem (and others), a while ago I submitted to Ruby/Rake the following pull request to correct this problem. It is still open—and relatively recently it has gotten some attention:

Pull request to Ruby/Rake: Sh fully echoes commands which error exit

Please see what @deivid-rodriguez says at the bottom.

Previously I didn't seek "social" support for this pull request. (I assumed I could argue for it as abstractly good, and deserving of acceptance.) It hasn't been accepted yet; I think that's because it lacks much expression of interest from the (Ruby) community.

If this repository expresses interest in the above pull request, then I suppose it may be accepted.

@MarkDBlackwell
Copy link
Contributor Author

@DanielKehoe Recently, ruby/rake merged the above pull request. :)

@DanielKehoe
Copy link
Member

My gosh that took 6 years to merge. A minor but useful improvement. Good work, Mark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants