Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle install failure #1472

Open
4 tasks done
Ushie opened this issue Nov 7, 2023 · 3 comments · May be fixed by #1473
Open
4 tasks done

feat: handle install failure #1472

Ushie opened this issue Nov 7, 2023 · 3 comments · May be fixed by #1473
Assignees
@oSumAtrIX
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@Ushie
Copy link
Member

Ushie commented Nov 7, 2023

Feature description

Add a shared AlertDialog component that can handle all package manager install failure flags and have an associated action to resolve the reason of failure if applicable

Motivation

It's important to handle these failures, and communicate the reason in a simplified manner to the user, Package Installer most of the time throws the most useless error "Could not install" and doesn't communicate anything, so we can communicate it ourselves instead and instruct them on the solution

Additional context

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@Ushie Ushie added Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Nov 7, 2023
@oSumAtrIX
Copy link
Member

Is a design already proposed?

@Ushie
Copy link
Member Author

Ushie commented Nov 7, 2023

image

Use this as the base idea, you can look at other AlertDialogs across the repository to see how you can exactly achieve this

@Ushie Ushie mentioned this issue Nov 7, 2023
Closed
@Ushie
Copy link
Member Author

Ushie commented Nov 7, 2023

Also it can be possible to add our own installation failures, like this situation for example:

"Alert user that the patched app version does not match the installed app and inform them that mounting will not be possible, guide them on how to resolve the mismatch" from the issue I mentioned above

@oSumAtrIX oSumAtrIX linked a pull request Nov 8, 2023 that will close this issue
feat: Add installer status dialog #1473
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oSumAtrIX oSumAtrIX

Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
Development of ReVanced
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add installer status dialog ReVanced/revanced-manager
2 participants
@oSumAtrIX @Ushie