Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ? character in basename for browser history. #566

Closed
wants to merge 1 commit into from
Closed

Allow ? character in basename for browser history. #566

wants to merge 1 commit into from

Conversation

goffioul
Copy link

@goffioul goffioul commented Feb 7, 2018

When dealing with startup URL like http://example.com/index.html?foo, it
is not possible to define a basename like '/index.html?foo', the
basename matching utility does not escape regex special characters from
the specified prefix. This change escapes question mark characters,
likely the most common use case.

When dealing with startup URL like http://example.com/index.html?foo, it
is not possible to define a basename like '/index.html?foo', the
basename matching utility does not escape regex special characters from
the specified prefix. This change escapes question mark characters,
likely the most common use case.
@mjackson mjackson mentioned this pull request Mar 27, 2019
25 tasks
@mjackson mjackson closed this in baef934 Mar 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2019
forl pushed a commit to forl/history that referenced this pull request Aug 12, 2019
mjackson added a commit that referenced this pull request Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant