Ignore <base href> in hash history replace #577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #574 dealing with
createHashHistory
's support for the<base>
tag. I didn't know how to simulate full-page refresh navigation in the tests but here's how you can manually test it:Edit index.html to have
<base href="/the/base">
in the head and switch to hashHistory. Navigating to the local server without a hash at the end of the url will now redirect you tohttp://localhost:8080/the/base/#/
in all browsers except for IE where it will redirect tohttp://localhost:8080/#/
With this change it always behaves as in IE, redirecting to
http://localhost:8080/#/
in all browsers.The related PR #578 changes the output of
createHref
when a base tag is present.