New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.1 #6739
Comments
The following PRs could probably get merged too. I don't see any open review comments on them. The first isn't likely to break things and the latter is just a doc update.
All other PRs I checked are either new features or have unresolved comments. |
@mjackson Is the release script all good? If so, I can make sure it happens. |
BTW, docs fixes don't depend on a release. They go out as soon as they're merged into the |
The fixes here would be so nice. That one with the |
Sorry for additional noise, this really would be extremely beneficial to get the patches out. We bit the bullet and made the jump to 5.0 for the redirect bug to bite us only after bumping in a couple layers of dependencies and now we're in a bind waiting for either the patches or to do another set of version changes to revert across the dependency chain. |
We also had only 19 issues. 17 of them closed as support requests, duplicates and so on. The remaining two are 1 discussion / feature request and 1 that's probably an upstream bug to And with the pending overhaul of the roadmap announced in Ryans blogpost, there isn't much in terms of feature development going on (here) either. The only big development was the overhaul of the @mjackson @timdorr Is there any block we can do something about / help with? |
I just need confirmation the automated release scripts will work. I don't want to screw up and cause a false alarm 😬 |
Ditto on the |
@timdorr I'm assuming you're deferring to @mjackson or @ryanflorence |
Yep, I need to know from either of them. |
Yes, I believe the release script is solid. I used it to release 5.0. I'll cut the release now just in case there's a problem, but it should be good to go. |
Looks like the Edit: Nevermind, I forgot to build. |
OK, this should be good to go in 0c9a10d Will release as 5.0.1 as soon as https://travis-ci.org/ReactTraining/react-router/builds/541475597 finishes For the record @timdorr , the process I used was this:
That's all any of us should have to do now that the release process is fully automated. |
All done! I'll update the release notes. |
Cool, thanks for confirming! |
Not sure if anyone else has seen this issue with and i saw that project get added to my yarn lock BUT it didnt show up in the node modules for some strange reason. When i ran my tests I was seeing... installed 'mini-create-react-context' manually and everything worked, but i dont think i should need to do that right? |
Can we release 5.0.1 soon-ish?
I ask because the license issue of
react-react-context
is blocking the upgrade for me.But also because bug reports have slowed down a lot lately. This is probably as stable as it gets until new features get introduced.
The changelog so far would be:
Bugfixes:
Redirect
in some scenarios (017f692 and 2ce1d32)Redirect
throwing an exception in StaticRouter without context (3ccbd19)matchPath
that caused an exception for empty paths (7bd1407)Link onClick
(82ce94c)withRouter()
(56c829b)Changes:
withRouter()
HOC. (10d78bb)withRouter
is used outside aRouter
(10d78bb)mini-create-react-context
(992af48)P.S.: Sorry for not using the issue template.
The text was updated successfully, but these errors were encountered: