You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A colleague and I collaborated on a GC improvement to this library ~6 months ago after getting the PR merged pinned to that merged commit in cocoa pods. Now we're looking at migrating to SPM and it's forcing folks to discuss forking and maintaining our own copy of ReactiveSwift which I'd prefer to avoid.
I think @mluisbrown is the maintainer who reviewed and merged our PR.
The text was updated successfully, but these errors were encountered:
Although if it's the lack of a release tag that's prompting your discussion of creating a fork, you can still use ReactiveSwift from SPM by pointing to a specific commit or branch.
Although if it's the lack of a release tag that's prompting your discussion of creating a fork, you can still use ReactiveSwift from SPM by pointing to a specific commit or branch.
That's what I encouraged them to do/we will be doing in the short term.
I think the general concern is that pinning to a specific commit isn't a good look long term for a dependency.
A colleague and I collaborated on a GC improvement to this library ~6 months ago after getting the PR merged pinned to that merged commit in cocoa pods. Now we're looking at migrating to SPM and it's forcing folks to discuss forking and maintaining our own copy of ReactiveSwift which I'd prefer to avoid.
I think @mluisbrown is the maintainer who reviewed and merged our PR.
The text was updated successfully, but these errors were encountered: