New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a problem with inserting Blob/ArrayBuffer ！ #392

Open

LLLLLLiulei opened this issue Aug 3, 2020 · 4 comments

Assignees

LLLLLLiulei commented Aug 3, 2020 •

edited

Member

Brooooooklyn commented Aug 3, 2020

https://github.com/ReactiveDB/core/blob/master/src/utils/clone.ts

Brooooooklyn assigned Saviio

Contributor

Saviio commented Aug 5, 2020

@Brooooooklyn seems like function: forEach does not support for ab & dataview, i may try to fix it when i have time

Author

LLLLLLiulei commented Aug 5, 2020

Try to use slice to clone it ?

Contributor

Saviio commented Aug 5, 2020 •

edited

not a clone problem, this issue come from the implementation of forEach, as it cannot iterate ab correctly.

see also:

core/src/utils/for-each.ts

Line 25 in 0ffa153

} else if (target instanceof Array) {

new ArrayBuffer() instanceof Array is false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment