Skip to content

Commit

Permalink
fix(audit): will not crash if duration is synchronous (#3608)
Browse files Browse the repository at this point in the history
closes #2743
  • Loading branch information
benlesh committed Apr 26, 2018
1 parent b948e65 commit 76b7e27
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions spec/operators/audit-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,18 @@ describe('Observable.prototype.audit', () => {
expectSubscriptions(e2.subscriptions).toBe(e2subs);
});

it('should mirror source if durations are synchronous observables', () => {
const e1 = hot('abcdefabcdefabcdefabcdefa|');
const e1subs = '^ !';
const e2 = Rx.Observable.of('one single value');
const expected = 'abcdefabcdefabcdefabcdefa|';

const result = e1.audit(() => e2);

expectObservable(result).toBe(expected);
expectSubscriptions(e1.subscriptions).toBe(e1subs);
});

it('should raise error as soon as just-throw duration is used', () => {
const e1 = hot('----abcdefabcdefabcdefabcdefa|');
const e1subs = '^ ! ';
Expand Down
2 changes: 1 addition & 1 deletion src/internal/operators/audit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class AuditSubscriber<T, R> extends OuterSubscriber<T, R> {
this.destination.error(errorObject.e);
} else {
const innerSubscription = subscribeToResult(this, duration);
if (innerSubscription.closed) {
if (!innerSubscription || innerSubscription.closed) {
this.clearThrottle();
} else {
this.add(this.throttled = innerSubscription);
Expand Down

0 comments on commit 76b7e27

Please sign in to comment.