fix(audit): fix crashes in case of the duration Observable completes #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the problem when subscribeToResult() returns null it will crash described by @deadbeef84 2595
kwonoj
reviewed
Jul 12, 2017
spec/operators/audit-spec.ts
Outdated
| @@ -139,6 +139,18 @@ describe('Observable.prototype.audit', () => { | |||
| expectSubscriptions(e1.subscriptions).toBe(e1subs); | |||
| }); | |||
|
|
|||
| it('should mirror source if durations are Observable.of()', () => { | |||
There was a problem hiding this comment.
I'd rather name it for synchronous observable instead of specifically say of operator (this could happen for any synchronous observable).
asnov
referenced
this pull request
Jul 12, 2017
…le.empty() (#2595) * fix(audit): mirror source if durations are Observable.empty() * refactor(audit): respond to feedback.
Generated by 🚫 dangerJS |
--0.0KB-green.svg?style=flat-square){kind=icon}
-0.0KB-red.svg?style=flat-square){kind=icon}
change test name
kwonoj
approved these changes
Jul 12, 2017
|
I'm labelling this as patch for now. |
|
@benlesh I think this can go with 5.5? |
|
Why is this still not fixed? :( |
benlesh
pushed a commit
to benlesh/rxjs
that referenced
this pull request
Apr 26, 2018
|
Closing for #3608 |
benlesh
added a commit
that referenced
this pull request
Apr 26, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix the problem when subscribeToResult() returns null it will crash described by @deadbeef84
Related issue (if exists):
fixes #2595