fix(WebSocketSubject): Check if WebSocket exists before using it #3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonnet
changed the title
benlesh
requested changes
May 15, 2018
| @@ -7,6 +7,7 @@ import { ReplaySubject } from '../../ReplaySubject'; | |||
| import { Observer, NextObserver } from '../../types'; | |||
| import { tryCatch } from '../../util/tryCatch'; | |||
| import { errorObject } from '../../util/errorObject'; | |||
| import { root } from '../../util/root'; | |||
There was a problem hiding this comment.
We want to get away from using root.
There was a problem hiding this comment.
@benlesh Updated this to remove root and just see if WebSocket exists in the global scope. Is there a specific reason we're moving away from using root?
There was a problem hiding this comment.
It causes weird issues with some bundling setups, and it's just unnecessary code for the most part.
bbonnet
changed the title
benlesh
approved these changes
May 21, 2018
|
thanks, @bbonnet! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Check to make sure that the
WebSocketconstructor is in the root before using it. This is currently breaking in Node.Related issue (if exists):
#3692