3.x: Add onBackpressureReduce operator #7129
Merged
+452
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update local fork with latest
|
Could you please rebase this onto a fresh |
Codecov Report
@@ Coverage Diff @@
## 3.x #7129 +/- ##
============================================
- Coverage 99.54% 99.52% -0.03%
- Complexity 6703 6708 +5
============================================
Files 744 745 +1
Lines 47298 47327 +29
Branches 6373 6375 +2
============================================
+ Hits 47083 47100 +17
- Misses 96 101 +5
- Partials 119 126 +7 Continue to review full report at Codecov.
|
# Conflicts: # src/main/java/io/reactivex/rxjava3/core/Flowable.java # src/main/java/io/reactivex/rxjava3/internal/operators/flowable/AbstractBackpressureThrottlingSubscriber.java # src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableOnBackpressureLatest.java # src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableOnBackpressureReduce.java # src/test/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableOnBackpressureReduceTest.java
done |
akarnokd
requested changes
Dec 9, 2020
| "The reducer returned a null value" | ||
| )); | ||
| } | ||
| drain(); |
There was a problem hiding this comment.
drain() should be outside the try-catch.
.../java/io/reactivex/rxjava3/internal/operators/flowable/FlowableOnBackpressureReduceWith.java
Outdated
Show resolved
Hide resolved
akarnokd
reviewed
Dec 9, 2020
akarnokd
approved these changes
Dec 9, 2020
vanniktech
approved these changes
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added one more overloaded version of onBackpressureReduce operator
Changes:
FlowableOnBackpressureReduceWithAbstractBackpressureThrottlingSubscriberhas two types now T - upstream, R- downstream and inherited by 3 classes:BackpressureLatestSubscriber,BackpressureReduceSubscriberandBackpressureReduceWithSubscribersuggest to review and merge after this PR merged