-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Io Scheduler, Scheduled worker release. #7160
Merged
Merged
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgc-code
commented
Jan 25, 2021
akarnokd
requested changes
Jan 25, 2021
src/test/java/io/reactivex/rxjava3/schedulers/IoScheduledReleaseTest.java
Outdated
Show resolved
Hide resolved
akarnokd
approved these changes
Jan 25, 2021
Codecov Report
@@ Coverage Diff @@
## 3.x #7160 +/- ##
============================================
+ Coverage 99.49% 99.53% +0.03%
Complexity 6708 6708
============================================
Files 745 745
Lines 47327 47332 +5
Branches 6375 6376 +1
============================================
+ Hits 47089 47111 +22
+ Misses 104 98 -6
+ Partials 134 123 -11 Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IoScheduler
releases the workers back to the pool to be reused optimistically to reduce the number of threads being created. This could lead to deadlocks in some situations like this one:As discussed on #7153, this PR allow to configure this behaviour.
Enabling
rx3.io-scheduled-release
will guarantee that workers are not reused until all the processing has finished.Once we merge this we, I can create a similar PR for the
2.x
branch