Skip to content

3.x: Add onSubscribe hook to ParallelFlowable operators #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

akarnokd
Copy link
Member

Parallel operators were missing an RxJavaPlugins.onSubscribe hook.

Resolves #7190

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@akarnokd akarnokd added the 3.x label Feb 17, 2021
@akarnokd akarnokd added this to the 3.1 milestone Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #7191 (5e33ef0) into 3.x (abecb9a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7191      +/-   ##
============================================
- Coverage     99.58%   99.53%   -0.05%     
- Complexity     6754     6756       +2     
============================================
  Files           747      747              
  Lines         47350    47374      +24     
  Branches       6367     6382      +15     
============================================
+ Hits          47153    47155       +2     
- Misses           91      101      +10     
- Partials        106      118      +12     
Impacted Files Coverage Δ Complexity Δ
...main/java/io/reactivex/rxjava3/core/Scheduler.java 100.00% <100.00%> (ø) 16.00 <2.00> (ø)
...3/internal/operators/parallel/ParallelCollect.java 100.00% <100.00%> (ø) 7.00 <3.00> (ø)
...internal/operators/parallel/ParallelConcatMap.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
...ternal/operators/parallel/ParallelDoOnNextTry.java 100.00% <100.00%> (ø) 6.00 <4.00> (ø)
...a3/internal/operators/parallel/ParallelFilter.java 100.00% <100.00%> (ø) 6.00 <4.00> (ø)
...internal/operators/parallel/ParallelFilterTry.java 100.00% <100.00%> (ø) 6.00 <4.00> (ø)
...3/internal/operators/parallel/ParallelFlatMap.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
...al/operators/parallel/ParallelFlatMapIterable.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
...internal/operators/parallel/ParallelFromArray.java 100.00% <100.00%> (ø) 5.00 <3.00> (ø)
...rnal/operators/parallel/ParallelFromPublisher.java 100.00% <100.00%> (ø) 4.00 <2.00> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abecb9a...da2db04. Read the comment docs.

@akarnokd akarnokd merged commit 22c5e0b into ReactiveX:3.x Feb 24, 2021
@akarnokd akarnokd deleted the ParallelOnSubscribeHooks branch February 24, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.x & 3.x Question: Will ParallelFlowable support RxJavaPlugins#onFlowableSubscribe?
1 participant