Skip to content

Modernize gradle plugin block, change maven to maven-publish #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

benjamintboyle
Copy link
Contributor

Move gradle plugins to block at top of file per gradle recommendations.
Change deprecated maven plugin to maven-publish as in Gradle 7.0 it will
be removed. Several other minor updates to gradle file including, removing
semi-colons, changing println to use built-in logger.

Move gradle plugins to block at top of file per gradle recommendations.
Change deprecated maven plugin to maven-publish as in Gradle 7.0 it will
be removed. Several other minor updates to gradle file including, removing
semi-colons, changing println to use built-in logger.
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #7219 (c0301bc) into 3.x (c38ea99) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7219      +/-   ##
============================================
+ Coverage     99.50%   99.56%   +0.05%     
+ Complexity     6757     6756       -1     
============================================
  Files           747      747              
  Lines         47391    47391              
  Branches       6382     6382              
============================================
+ Hits          47157    47183      +26     
+ Misses          105       93      -12     
+ Partials        129      115      -14     
Impacted Files Coverage Δ Complexity Δ
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-2.39%) 2.00% <0.00%> (ø%)
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) 44.00% <0.00%> (-1.00%)
...lowable/FlowableFlatMapCompletableCompletable.java 98.68% <0.00%> (-1.32%) 3.00% <0.00%> (ø%)
...java3/internal/operators/flowable/FlowableZip.java 98.97% <0.00%> (-1.03%) 6.00% <0.00%> (ø%)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 99.18% <0.00%> (-0.82%) 2.00% <0.00%> (ø%)
.../operators/observable/ObservableCombineLatest.java 99.38% <0.00%> (-0.62%) 6.00% <0.00%> (ø%)
.../reactivex/rxjava3/observers/BaseTestConsumer.java 99.46% <0.00%> (-0.54%) 74.00% <0.00%> (-1.00%)
...a3/internal/operators/flowable/FlowableCreate.java 99.02% <0.00%> (-0.33%) 6.00% <0.00%> (ø%)
...ternal/operators/observable/ObservableFlatMap.java 98.22% <0.00%> (+0.35%) 3.00% <0.00%> (ø%)
...operators/flowable/FlowableConcatMapScheduler.java 99.60% <0.00%> (+0.39%) 4.00% <0.00%> (ø%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c38ea99...c0301bc. Read the comment docs.

akarnokd
akarnokd previously approved these changes Mar 26, 2021
@akarnokd akarnokd dismissed their stale review March 26, 2021 21:39

found some issues

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@akarnokd akarnokd merged commit 11b50a5 into ReactiveX:3.x Mar 26, 2021
@benjamintboyle benjamintboyle deleted the gradle-plugin-block branch March 29, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants