Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.x: Add onDropped callbacks to operators #7458

Closed
6 tasks done
akarnokd opened this issue Aug 8, 2022 · 8 comments
Closed
6 tasks done

3.x: Add onDropped callbacks to operators #7458

akarnokd opened this issue Aug 8, 2022 · 8 comments
Labels
3.x Enhancement
Milestone
3.2

Comments

@akarnokd
Copy link
Member

akarnokd commented Aug 8, 2022 •
edited

Add onDropped callback overloads to most operators that drop items that can't be recovered by other means.

  • throttleLatest PR #7457
  • throttleFirst PR #7482
  • throttleLast / sample PR #7488
  • throttleWithTimeout / debounce PR #7510
  • onBackpressureLatest (PR #7458)
  • onBackpressureBuffer (PR #7567)
    • 📓 The current overloads with Action are somewhat unhelpful, however, we'll have to add overloads in a way that avoids lambda ambiguity.
@akarnokd akarnokd added this to the 3.2 milestone Aug 8, 2022
@Desislav-Petrov
Copy link
Contributor

Hi - do you need any help with some of these?

@akarnokd
Copy link
Member Author

@Desislav-Petrov you can have a stab at them. I won't have the time for weeks although there is no rush either.

@Desislav-Petrov
Copy link
Contributor

Desislav-Petrov commented Oct 18, 2022 •
edited

Thanks, starting this week and will follow your PR per method strategy - I've started with throttleFirst

This was referenced Nov 4, 2022
Closed
Merged
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Nov 7, 2022
@Desislav-Petrov
Add onDropped callback for throttleFirst - addresses ReactiveX#7458
7a2792a
akarnokd pushed a commit that referenced this issue Nov 7, 2022
@Desislav-Petrov
Add onDropped callback for throttleFirst - addresses #7458 (#7482)
3b0d948
@Desislav-Petrov
Copy link
Contributor

hi @akarnokd - i'm looking at throttleLast. From what I see, we should change the public void onNext(T t) method in the *SampleTimed class. More precisely, when we do the lazySet() we should check if a value exists there - if so we need to call the onDropped with this value as this is what we're dropping.
Does this make sense?

@akarnokd
Copy link
Member Author

@Desislav-Petrov lazySets have to be made getAndSet: https://github.com/ReactiveX/RxJava/blob/3.x/src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableThrottleLatest.java#L130

@Desislav-Petrov
Copy link
Contributor

Thx - leave this with me, will do a PR shortly.

Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Nov 30, 2022
@Desislav-Petrov
Adding onDropped callback to throttleLast as a part of ReactiveX#7458
0d189cd
@Desislav-Petrov Desislav-Petrov mentioned this issue Nov 30, 2022
Merged
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Dec 2, 2022
@Desislav-Petrov
Adding onDropped callback to throttleLast as a part of ReactiveX#7458
65ba785
akarnokd pushed a commit that referenced this issue Dec 3, 2022
@Desislav-Petrov
Adding onDropped callback to throttleLast as a part of #7458 (#7488)
1104c09
@Desislav-Petrov
Copy link
Contributor

taking a look at throttleWithTimeout / debounce next

Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Jan 8, 2023
@Desislav-Petrov
Add onDropped callback for throttleWithTimeout - ReactiveX#7458
dabe4d5
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Jan 8, 2023
@Desislav-Petrov
Add onDropped callback for throttleWithTimeout - ReactiveX#7458
28f6250
@akarnokd akarnokd mentioned this issue Jan 9, 2023
Merged
akarnokd pushed a commit that referenced this issue Jan 9, 2023
@Desislav-Petrov
Add onDropped callback for throttleWithTimeout - #7458 (#7510)
bf8da15
@Desislav-Petrov
Copy link
Contributor

Looking at onBackpressureLatest next

Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Mar 18, 2023
@Desislav-Petrov
Add onDropped callback for onBackpressureLatest - ReactiveX#7458
9e908da
@akarnokd akarnokd mentioned this issue Mar 18, 2023
Merged
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Mar 18, 2023
@Desislav-Petrov
Add onDropped callback for onBackpressureLatest - ReactiveX#7458
5a7fbfc
Desislav-Petrov added a commit to Desislav-Petrov/RxJava that referenced this issue Mar 18, 2023
@Desislav-Petrov
Add onDropped callback for onBackpressureLatest - ReactiveX#7458
92eaf96
akarnokd pushed a commit that referenced this issue Mar 21, 2023
@Desislav-Petrov
Add onDropped callback for onBackpressureLatest - #7458 (#7542)
4e2e9a2
akarnokd added a commit to akarnokd/RxJava that referenced this issue May 22, 2023
@akarnokd
3.x: Add onDropped callback to onBackpressureBuffer
39748d9 
Related ReactiveX#7458
@akarnokd akarnokd mentioned this issue May 22, 2023
Merged
akarnokd added a commit that referenced this issue May 23, 2023
@akarnokd
3.x: Add onDropped callback to onBackpressureBuffer (#7567)
919d310 
* 3.x: Add onDropped callback to onBackpressureBuffer

Related #7458

* MBE is expected

* Annotate with experimental
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Enhancement
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
2 participants
@akarnokd @Desislav-Petrov