3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException #7459

akarnokd · 2022-08-08T13:41:55Z

Extend MissingBackpressureException with a standard message string and a static methods to create the exception with the standard message. This will make sure every case reports the same consistent message.

In addition, the queue overflows now have a separate exception class QueueOverflowException. This exception should not happen during normal operations and is mainly there to detect misuse or bugs in operators. Consequencly, even though many places used to signal MissingBackpressureException for such queue overflows, there was no reason to check for this specific exception class outside developing RxJava itself.

ThrottleLatest needs to be updated after #7457

codecov · 2022-08-08T14:14:43Z

Codecov Report

Merging #7459 (2f858bd) into 3.x (ef51a90) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x    #7459      +/-   ##
============================================
- Coverage     99.55%   99.54%   -0.02%     
- Complexity     6781     6786       +5     
============================================
  Files           751      752       +1     
  Lines         47482    47489       +7     
  Branches       6378     6379       +1     
============================================
+ Hits          47271    47272       +1     
- Misses           93       97       +4     
- Partials        118      120       +2

Impacted Files	Coverage Δ
...java3/exceptions/MissingBackpressureException.java	`100.00% <100.00%> (ø)`
...vex/rxjava3/exceptions/QueueOverflowException.java	`100.00% <100.00%> (ø)`
...x/rxjava3/internal/jdk8/FlowableFlatMapStream.java	`100.00% <100.00%> (ø)`
...ernal/operators/completable/CompletableConcat.java	`100.00% <100.00%> (ø)`
...l/operators/flowable/BlockingFlowableIterable.java	`100.00% <100.00%> (ø)`
...internal/operators/flowable/FlowableConcatMap.java	`100.00% <100.00%> (ø)`
...nal/operators/flowable/FlowableConcatMapEager.java	`100.00% <100.00%> (ø)`
...operators/flowable/FlowableConcatMapScheduler.java	`99.60% <100.00%> (ø)`
...a3/internal/operators/flowable/FlowableCreate.java	`99.02% <100.00%> (ø)`
.../internal/operators/flowable/FlowableDebounce.java	`100.00% <100.00%> (ø)`
... and 42 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

vanniktech · 2022-08-08T14:22:25Z

src/main/java/io/reactivex/rxjava3/exceptions/MissingBackpressureException.java

+     * without synchronization. Rarely, it is an indication of bugs inside RxJava
+     * @since 3.1.6
+     */
+    public static final String QUEUE_OVERFLOW_MESSAGE = "Queue overflow due to illegal concurrent onNext calls or a bug in RxJava";


These could be private though, right?

3rd party implementations should be able to verify they got this exact message:

assertEquals(ex.getMessage(), MissingBackpressureException.QUEUE_OVERFLOW_MESSAGE);

Hmm should not we then just have two different exceptions both having only one public constructor which contains the exact message and then you simply check for its type which is superior than the String message?

Alright, let's introduce a separate exception.

vanniktech · 2022-08-08T16:41:38Z

src/main/java/io/reactivex/rxjava3/exceptions/QueueOverflowException.java

+     * Constructs a QueueOverflowException with the given message but no cause.
+     * @param message the error message
+     */
+    public QueueOverflowException(String message) {


Why would we need this?

In case 3rd party users would want to have a custom message.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.5` -> `3.1.6` | --- ### Release Notes <details> <summary>ReactiveX/RxJava</summary> ### [`v3.1.6`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.6) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.6%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.6) ##### API changes - Add an overload to `throttleLatest` operator with an `onDropped` callback. (<a href='https://github.com/ReactiveX/RxJava/issues/7457'>[#7457](https://togithub.com/ReactiveX/RxJava/issues/7457)</a>) - Add an overload to `throttleFirst` operator with an `onDropped` callback. (<a href='https://github.com/ReactiveX/RxJava/issues/7482'>[#7482](https://togithub.com/ReactiveX/RxJava/issues/7482)</a>) - Add an overload to `throttleLast` operator with an `onDropped` callback. (<a href='https://github.com/ReactiveX/RxJava/issues/7488'>[#7488](https://togithub.com/ReactiveX/RxJava/issues/7488)</a>) - Add an overload to `throttleWithTimeout` operator with an `onDropped` callback. (<a href='https://github.com/ReactiveX/RxJava/issues/7510'>[#7510](https://togithub.com/ReactiveX/RxJava/issues/7510)</a>) ##### Bugfixes - Fix a race condition in `Single.timeout` that prevented the timeout signal from happening. (<a href='https://github.com/ReactiveX/RxJava/issues/7515'>[#7515](https://togithub.com/ReactiveX/RxJava/issues/7515)</a>) ##### Documentation - Fix formatting in `TestObserver/Consumer/Subscriber` javadoc html. (<a href='https://github.com/ReactiveX/RxJava/issues/7442'>[#7442](https://togithub.com/ReactiveX/RxJava/issues/7442)</a>) - Fix typo in `BehaviorSubject.java`. (<a href='https://github.com/ReactiveX/RxJava/issues/7452'>[#7452](https://togithub.com/ReactiveX/RxJava/issues/7452)</a>) - Fix grammar about cancellation in `Schedulers` javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7453'>[#7453](https://togithub.com/ReactiveX/RxJava/issues/7453)</a>) - Change `@coded` tag to `@code` tag. (<a href='https://github.com/ReactiveX/RxJava/issues/7463'>[#7463](https://togithub.com/ReactiveX/RxJava/issues/7463)</a>) - Fix `fromCompletionStage` javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7508'>[#7508](https://togithub.com/ReactiveX/RxJava/issues/7508)</a>) ##### Other - Add missing `@NonNull` annotation to `Maybe` type argument. (<a href='https://github.com/ReactiveX/RxJava/issues/7436'>[#7436](https://togithub.com/ReactiveX/RxJava/issues/7436)</a>) - Remove redundant interface declarations. (<a href='https://github.com/ReactiveX/RxJava/issues/7438'>[#7438](https://togithub.com/ReactiveX/RxJava/issues/7438)</a>) - Standardize `MissingBackpressureException` message, introduce `QueueOverflowException`. (<a href='https://github.com/ReactiveX/RxJava/issues/7459'>[#7459](https://togithub.com/ReactiveX/RxJava/issues/7459)</a>) - Update `Flowable.throttleLatest` `MissingBackpressureException` message. (<a href='https://github.com/ReactiveX/RxJava/issues/7460'>[#7460](https://togithub.com/ReactiveX/RxJava/issues/7460)</a>) - Fix cancellation order in `throttleFirst`. (<a href='https://github.com/ReactiveX/RxJava/issues/7484'>[#7484](https://togithub.com/ReactiveX/RxJava/issues/7484)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

akarnokd added 2 commits August 8, 2022 15:34

3.x: Standardize MissingBackpressureException messages

4d77314

Use the correct message.

0d78932

akarnokd added Cleanup 3.x labels Aug 8, 2022

akarnokd added this to the 3.2 milestone Aug 8, 2022

Fix tests

cc04ccf

vanniktech approved these changes Aug 8, 2022

View reviewed changes

akarnokd added 2 commits August 8, 2022 17:22

Add QueueOverflowException, fix tests

4b612f6

Update CompletableConcatTest.java

2f858bd

vanniktech approved these changes Aug 8, 2022

View reviewed changes

akarnokd changed the title ~~3.x: Standardize MissingBackpressureException messages~~ 3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException Aug 8, 2022

akarnokd merged commit 2edba23 into ReactiveX:3.x Aug 8, 2022

akarnokd deleted the MissingBackpressureExceptionStandardMessage branch August 8, 2022 18:45

akarnokd mentioned this pull request Aug 9, 2022

3.x: Update Flowable.throttleLatest MissingBackpressureException message #7460

Merged

akarnokd mentioned this pull request Jan 16, 2023

Release 3.1.6 preparations #7516

Closed

glovo-renovate bot mentioned this pull request Jan 18, 2023

[Bump] Update all non-major dependencies Glovo/glovo-interview-android-base#10

Closed

1 task

This was referenced Jan 19, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 slackhq/slack-gradle-plugin#220

Merged

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 slackhq/circuit#400

Merged

renovate bot mentioned this pull request Jan 30, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 square/retrofit#3811

Merged

1 task

renovate bot mentioned this pull request Feb 21, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 tuskyapp/Tusky#3353

Merged

1 task

mend-for-github-com bot mentioned this pull request Mar 21, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.8 Uncleken13/coherence#43

Open

1 task

This was referenced Mar 28, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 saurabhpro/Microservices#53

Merged

fix(deps): update renovate dependency scan saurabhpro/JAVA#129

Merged

This was referenced Apr 15, 2023

fix(deps): update dependency io.reactivex.rxjava3:rxjava to v3.1.6 micronaut-projects/micronaut-kubernetes#557

Merged

chore(deps): update dependency io.reactivex.rxjava3:rxjava to v3.1.6 liu-wanshun/rxandroid-disposables#5

Merged

renovate bot mentioned this pull request Jul 9, 2023

Update dependency io.reactivex.rxjava3:rxjava to v3.1.6 LachlanMcKee/appyx#22

Open

1 task

renovate bot mentioned this pull request Sep 6, 2023

chore(deps): update dependency io.reactivex.rxjava3:rxjava to v3.1.7 FilippoVissani/assignment-02#3

Open

1 task

renovate bot mentioned this pull request Jan 25, 2024

Update dependency io.reactivex.rxjava3:rxjava to v3.1.8 elijah-team/prolific-remnant#32

Merged

1 task

renovate bot mentioned this pull request Apr 10, 2024

Update dependency io.reactivex.rxjava3:rxjava to v3.1.8 ku-ring/KU-Ring-Android#182

Merged

1 task

renovate bot mentioned this pull request May 5, 2024

Update dependency io.reactivex.rxjava3:rxjava to v3.1.8 IAmATeaPot418/java-testing-2#5

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException #7459

3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException #7459

akarnokd commented Aug 8, 2022 •

edited

codecov bot commented Aug 8, 2022 •

edited

vanniktech Aug 8, 2022

akarnokd Aug 8, 2022

vanniktech Aug 8, 2022

akarnokd Aug 8, 2022

akarnokd Aug 8, 2022

vanniktech Aug 8, 2022

akarnokd Aug 8, 2022

vanniktech Aug 8, 2022

3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException #7459

3.x: Standardize MissingBackpressureException message, introduce QueueOverflowException #7459

Conversation

akarnokd commented Aug 8, 2022 • edited

codecov bot commented Aug 8, 2022 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akarnokd commented Aug 8, 2022 •

edited

codecov bot commented Aug 8, 2022 •

edited