Convert CompletableOnErrorComplete$onError inner class to static #7575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 23, 2023 10:19
chintando
changed the title
chintando
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.x #7575 +/- ##
============================================
+ Coverage 99.53% 99.55% +0.02%
- Complexity 6799 6800 +1
============================================
Files 752 752
Lines 47705 47706 +1
Branches 6401 6401
============================================
+ Hits 47481 47495 +14
+ Misses 102 96 -6
+ Partials 122 115 -7
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Aug 23, 2023
Merged
Open
Merged
1 task
Open
1 task
1 task
This was referenced Aug 24, 2023
This was referenced Aug 24, 2023
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Aug 26, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
github-merge-queue bot
pushed a commit
to slackhq/slack-gradle-plugin
that referenced
this pull request
Aug 28, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
ashdavies
pushed a commit
to ashdavies/circuit
that referenced
this pull request
Sep 14, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | dependencies | patch | `3.1.6` -> `3.1.7` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ny40IiwidXBkYXRlZEluVmVyIjoiMzYuNTcuNCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
This was referenced Sep 16, 2023
Closed
1 task
nikclayton
pushed a commit
to pachli/pachli-android
that referenced
this pull request
Sep 27, 2023
…107) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | `3.1.6` -> `3.1.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/pachli/pachli-android). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
1 task
connyduck
pushed a commit
to tuskyapp/Tusky
that referenced
this pull request
Jan 3, 2024
…4092) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [io.reactivex.rxjava3:rxjava](https://togithub.com/ReactiveX/RxJava) | `3.1.6` -> `3.1.8` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ReactiveX/RxJava (io.reactivex.rxjava3:rxjava)</summary> ### [`v3.1.8`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.8) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.8%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.8) ##### Bugfixes - Fix `ObservableSwitchMap` `NullPointerException` due to cancel race. ([ReactiveX/RxJava#7597) ### [`v3.1.7`](https://togithub.com/ReactiveX/RxJava/releases/tag/v3.1.7) [Maven](http://search.maven.org/#artifactdetails%7Cio.reactivex.rxjava3%7Crxjava%7C3.1.7%7C) [JavaDocs](http://reactivex.io/RxJava/3.x/javadoc/3.1.7) ##### API changes - Add `onDropped` callback for `onBackpressureLatest`. (<a href='https://github.com/ReactiveX/RxJava/issues/7542'>[#​7542](https://togithub.com/ReactiveX/RxJava/issues/7542)</a>) - Add `onDropped` callback to `onBackpressureBuffer`. (<a href='https://github.com/ReactiveX/RxJava/issues/7567'>[#​7567](https://togithub.com/ReactiveX/RxJava/issues/7567)</a>) ##### Documentation - Change summary to caption, because summary is obsolete in HTML5. (<a href='https://github.com/ReactiveX/RxJava/issues/7534'>[#​7534](https://togithub.com/ReactiveX/RxJava/issues/7534)</a>) - Try using https to access the reactive streams javadoc. (<a href='https://github.com/ReactiveX/RxJava/issues/7535'>[#​7535](https://togithub.com/ReactiveX/RxJava/issues/7535)</a>) - Improve Javadoc of `Disposable`. ##### Other - Add minimum GitHub token permissions for workflows. (<a href='https://github.com/ReactiveX/RxJava/issues/7541'>[#​7541](https://togithub.com/ReactiveX/RxJava/issues/7541)</a>) - Create SECURITY.md (<a href='https://github.com/ReactiveX/RxJava/issues/7546'>[#​7546](https://togithub.com/ReactiveX/RxJava/issues/7546)</a>) - Add copyright and license to jar. (<a href='https://github.com/ReactiveX/RxJava/issues/7520'>[#​7520](https://togithub.com/ReactiveX/RxJava/issues/7520)</a>) - Convert `CompletableOnErrorComplete$onError` inner class to static. (<a href='https://github.com/ReactiveX/RxJava/issues/7575'>[#​7575](https://togithub.com/ReactiveX/RxJava/issues/7575)</a>) - Allow null accumulator type in the `collect(Collector)` operators. (<a href='https://github.com/ReactiveX/RxJava/issues/7590'>[#​7590](https://togithub.com/ReactiveX/RxJava/issues/7590)</a>) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/tuskyapp/Tusky). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Jan 4, 2024
fix(deps): update dependency io.reactivex.rxjava3:rxjava to v3.1.8
elijah-team/elevated-potential#41
Merged
Merged
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:
The OnError class not being static ends up holding a reference to predicate which will avoid it from being garbage collected.
Make OnError static and pass predicate to avoid leaking the predicate
See discussion in PR: #7574
Please give a description about what and why you are contributing, even if it's trivial.
Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.
Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an
empty,just,rangeof values as well as anerrorsource, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.