From 9910aedaaf8bb8a76fafbf2e730b29981bcb4c56 Mon Sep 17 00:00:00 2001 From: vthinkxie Date: Mon, 13 Dec 2021 19:24:31 +0800 Subject: [PATCH] fix: observable subscribe overloads close #6717 --- api_guard/dist/types/index.d.ts | 3 +-- src/internal/Observable.ts | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/api_guard/dist/types/index.d.ts b/api_guard/dist/types/index.d.ts index b1a2717d71..9edce873d3 100644 --- a/api_guard/dist/types/index.d.ts +++ b/api_guard/dist/types/index.d.ts @@ -435,8 +435,7 @@ export declare class Observable implements Subscribable { pipe(op1: OperatorFunction, op2: OperatorFunction, op3: OperatorFunction, op4: OperatorFunction, op5: OperatorFunction, op6: OperatorFunction, op7: OperatorFunction, op8: OperatorFunction): Observable; pipe(op1: OperatorFunction, op2: OperatorFunction, op3: OperatorFunction, op4: OperatorFunction, op5: OperatorFunction, op6: OperatorFunction, op7: OperatorFunction, op8: OperatorFunction, op9: OperatorFunction): Observable; pipe(op1: OperatorFunction, op2: OperatorFunction, op3: OperatorFunction, op4: OperatorFunction, op5: OperatorFunction, op6: OperatorFunction, op7: OperatorFunction, op8: OperatorFunction, op9: OperatorFunction, ...operations: OperatorFunction[]): Observable; - subscribe(observer?: Partial>): Subscription; - subscribe(next: (value: T) => void): Subscription; + subscribe(observerOrNext?: Partial> | ((value: T) => void)): Subscription; subscribe(next?: ((value: T) => void) | null, error?: ((error: any) => void) | null, complete?: (() => void) | null): Subscription; toPromise(): Promise; toPromise(PromiseCtor: typeof Promise): Promise; diff --git a/src/internal/Observable.ts b/src/internal/Observable.ts index abab383605..9a7e903be3 100644 --- a/src/internal/Observable.ts +++ b/src/internal/Observable.ts @@ -74,8 +74,7 @@ export class Observable implements Subscribable { return observable; } - subscribe(observer?: Partial>): Subscription; - subscribe(next: (value: T) => void): Subscription; + subscribe(observerOrNext?: Partial> | ((value: T) => void)): Subscription; /** @deprecated Instead of passing separate callback arguments, use an observer argument. Signatures taking separate callback arguments will be removed in v8. Details: https://rxjs.dev/deprecations/subscribe-arguments */ subscribe(next?: ((value: T) => void) | null, error?: ((error: any) => void) | null, complete?: (() => void) | null): Subscription; /**