Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink._addParentTeardownLogic is not a function rxjs node 6.3.2 and 6.2.2 #4135

Closed
alan-agius4 opened this issue Sep 14, 2018 · 3 comments
Closed

Comments

@alan-agius4
Copy link
Contributor

alan-agius4 commented Sep 14, 2018

Bug Report

Current Behavior

sink._addParentTeardownLogic is not a function

When using rxjs 6.2.2 and 6.3.2.

npm list rxjs

rxjs-tear-down-logic@1.0.0 
+-- fakes-dependency@1.0.0
| `-- rxjs@6.3.2
`-- rxjs@6.2.2

Reproduction

rxjs 6.3.2

const rxjs = require('rxjs');

const result = new rxjs.Observable(obs => {
	return rxjs.of(undefined).subscribe(obs)
})

module.exports = { result: result }

rxjs 6.2.2

const rxjs = require('rxjs');
const dependency = require('fakes-dependency');
const rxjs_operators = require('rxjs/operators');

rxjs.of(undefined).pipe(
	rxjs_operators.concatMap(() => dependency.result),
).toPromise()

Expected behavior
No Error

Environment

  • Runtime: Node v 8.9
  • RxJS version: 6.2.2 and 6.3.2
@benlesh
Copy link
Member

benlesh commented Sep 14, 2018

cc @cartant ... This is an issue with identifying a "trusted subscriber" between two different versions of RxJS. Basically one RxJS's Subscriber gets a Subscriber from the other RxJS (which doesn't have _addParentTeardownLogic)

This is directly related to our discussion yesterday that _addParentTeardownLogic is probably the wrong solution and needs to be removed/replaced.

@benlesh
Copy link
Member

benlesh commented Sep 14, 2018

#4106 is related to this. It should help resolve the issue.

@alan-agius4
Copy link
Contributor Author

Confirmed that it has been resolved in 6.3.3

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants