New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this implementation of endWith correct #4731
Comments
I've also hit issues with the
Here's the console output when running this test with rxjs 6.5.1:
|
I would have expected this to read:
or shorter
|
@CarstenLeue Looks like a bug, to me. But the fix is a little more subtle, as the array could contain a |
This is a really interesting bug. The tests pass because strings are iterable - so they are valid observable inputs. If the tests had used values other than strings, they would have failed! |
Met the same bug, was caught by a test for us |
Experiencing the same problem: https://jsbin.com/sasumoy/edit?html,js,console |
Fixed in #4735 |
Bug Report
rxjs 6.5.1 implements endWith as follows:
Is this really correct given that
concat
expectsobservables
as input, butarray
carries the individual items?The text was updated successfully, but these errors were encountered: