Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript config not strict enough #4968

Closed
cartant opened this issue Aug 15, 2019 · 1 comment
Closed

TypeScript config not strict enough #4968

cartant opened this issue Aug 15, 2019 · 1 comment
Labels
TS Issues and PRs related purely to TypeScript issues

Comments

@cartant
Copy link
Collaborator

cartant commented Aug 15, 2019

The TypeScript configuration used in this repo is insufficiently strict. The configuration should use "strict": true and should relax individual compiler options only if absolutely necessary.

For background, I have attempted to write a failing test to exercise the behvaiour described in this comment - that relates to a problem with the typing of the filter operator.

Unfortunately, I'm unable to do so as dtslint doesn't provide a mechanism for the types of errors involved in the snippet and because the compiler options used for the conventional tests are not strict enough - i.e. the snippet compiles without error.
cartant added a commit to cartant/rxjs that referenced this issue Aug 15, 2019
@cartant
chore: add test using comment snippet
7017c0c 
ReactiveX#4959 (comment)
ReactiveX#4968
benlesh pushed a commit that referenced this issue Aug 26, 2019
@cartant @benlesh
fix(types): add Boolean signature to filter (#4961)
259853e 
* fix(types): add Boolean signature to filter

Closes #4959

* chore: add test using comment snippet

#4959 (comment)
#4968
@cartant cartant mentioned this issue Sep 28, 2019
Merged
@cartant cartant mentioned this issue Oct 12, 2019
Closed
@cartant cartant added the TS Issues and PRs related purely to TypeScript issues label Oct 12, 2019
@cartant
Copy link
Collaborator Author

cartant commented Jan 21, 2020

Closed by #5244.

@cartant cartant closed this as completed Jan 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
TS Issues and PRs related purely to TypeScript issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cartant