Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports not resolving at all in some environments for RxJS 7. #6350

Closed
benlesh opened this issue May 4, 2021 · 3 comments
Closed

Imports not resolving at all in some environments for RxJS 7. #6350

benlesh opened this issue May 4, 2021 · 3 comments
Labels
7.x Issues and PRs for version 6.x bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented May 4, 2021

Issue:

When trying to import anything in RxJS 7, in some environments, in particular, stackblitz.com and codesandbox.io, the "rxjs" module does not seem to resolve. It worked fine with rxjs@7.0.0-rc.2, but not with rxjs@7.0.0. I suspect the references and the typesVersions addition are to blame. What a mess.

It seems to work fine in most other "real world" environments, from my testing though.

Broken codesandbox

Broken stackblitz

image

Behavior:

Error message: Cannot find module 'rxjs' or its corresponding type declarations.(2307)

Solution: rxjs@7 requires TypeScript 4.2 or higher please update TypeScript.

@benlesh benlesh added 7.x Issues and PRs for version 6.x AGENDA ITEM Flagged for discussion at core team meetings bug Confirmed bug labels May 4, 2021
@cyrilletuzi
Copy link

For information, it happens in real world too: example here (GitHub Actions checks of last commit of cyrilletuzi/angular-async-local-storage#642)

I linked to CI so you can see the issue directly, but same thing happen inside of VS Code.

@gritschf
Copy link

gritschf commented May 4, 2021

after updating to typescript 4.2.4 the problem would be gone. I say "would", because my angular project needs the typescript version to be < 4.2.0

@benlesh
Copy link
Member Author

benlesh commented May 4, 2021

@gritschf it's possible that codesandbox and stackblitz are still not TS 4.2. But I thought that stackblitz was, at least. 🤔

@benlesh benlesh pinned this issue May 5, 2021
@ReactiveX ReactiveX locked as resolved and limited conversation to collaborators May 5, 2021
@benlesh benlesh closed this as completed May 5, 2021
@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
7.x Issues and PRs for version 6.x bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants