Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of Non-ES5 APIs in ES5 Output in 7.5.5 #6942

Open
patrickkunka opened this issue Apr 21, 2022 · 3 comments
Open

Introduction of Non-ES5 APIs in ES5 Output in 7.5.5 #6942

patrickkunka opened this issue Apr 21, 2022 · 3 comments
Assignees
Labels
bug Confirmed bug

Comments

@patrickkunka
Copy link

patrickkunka commented Apr 21, 2022

Describe the bug

The most recent 7.5.5 release which includes #6842, introduces usage of Array.from() in Subject.prototype.next().

It may have been present in other areas of the codebase previously, but our codebase hits this path regularly, so it was noticed immediately on upgrade to this version.

We have to support older ES5 runtimes back to circa 2015 webkit browsers (for smart TVs), and avoid excessive polyfilling for performance and bundlesize reasons. Due to the fact RxJS is transpiled to ES5 by default, we've never had runtime issues on these platforms before. However on upgrade to 7.5.5 the absence of these more modern APIs now require that we polyfill around RxJS. Because we do not know which non ES5 APIs are in use, this is a somewhat difficult and risky task (if we miss something, we may experience fatal runtime errors).

What is the intention here? Should ES5 output be limited to ES5 APIs only, or should we be polyfilling?

Thanks!

Expected behavior

RxJS ES5 output should be limited to usage of ES5 language features and APIs only.

Reproduction code

No response

Reproduction URL

No response

Version

7.5.5

Environment

ES5 runtimes

Additional context

No response

@patrickkunka patrickkunka changed the title Introduction of non-es5 APIs in #6842 Introduction of Non-ES5 APIs in ES5 Output in 7.5.5 Apr 21, 2022
@kwonoj
Copy link
Member

kwonoj commented Apr 21, 2022

In my opinion, this looks unexpected mistake - we are supposed to support IE11 with version 7, and actual deprecation would be in v8. @benlesh thoughts?

@patrickkunka
Copy link
Author

Any update on this? Thanks

@benlesh benlesh added AGENDA ITEM Flagged for discussion at core team meetings bug Confirmed bug labels Sep 7, 2022
@benlesh
Copy link
Member

benlesh commented Feb 8, 2023

CORE TEAM: We should fix this in v7... v8 gets rid of ES5 support, so it's a non-issue there.

@benlesh benlesh self-assigned this Feb 8, 2023
@benlesh benlesh removed the AGENDA ITEM Flagged for discussion at core team meetings label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants