Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo on MPM website points to a 404 #7359

Open
Lykos opened this issue Oct 27, 2023 · 2 comments
Open

Logo on MPM website points to a 404 #7359

Lykos opened this issue Oct 27, 2023 · 2 comments

Comments

@Lykos
Copy link

Lykos commented Oct 27, 2023

Describe the bug

If you go to the NPM site of RxJS, there is a broken image with the alt text "RxJS Logo". It points to https://github.com/reactivex/rxjs/blob/HEAD/docs_app/src/assets/images/logos/Rx_Logo_S.png which doesn't exist.

Expected behavior

The logo should point to https://github.com/ReactiveX/rxjs/blob/0bd47eab10dec89f245b888f1f26e03cb36d2a78/apps/rxjs.dev/src/assets/images/logos/Rx_Logo_S.png which shows the incredibly cute logo of RxJS.

Reproduction code

Just open https://www.npmjs.com/package/rxjs and you'll see the problem.

Reproduction URL

https://www.npmjs.com/package/rxjs

Version

7.8.1

Environment

No response

Additional context

This is not an issue of the RxJS code itself but rather with its NPM configuration. If you tell me where this is configured, I can even try to fix it myself.

@jakovljevic-mladen
Copy link
Member

I don't know how it works.

The logo is now moved to https://raw.githubusercontent.com/reactivex/rxjs/HEAD/apps/rxjs.dev/src/assets/images/logos/Rx_Logo_S.png, but current stable version is now way off of the HEAD so pointing to https://raw.githubusercontent.com/reactivex/rxjs/HEAD/docs_app/src/assets/images/logos/Rx_Logo_S.png doesn't really work.

We should probably make it work to point to 7.x branch, or at least to the latest stable version of the library.

Because it works with https://raw.githubusercontent.com/reactivex/rxjs/7.x/docs_app/src/assets/images/logos/Rx_Logo_S.png or https://raw.githubusercontent.com/reactivex/rxjs/7.8.1/docs_app/src/assets/images/logos/Rx_Logo_S.png.

Maybe @benlesh has some option to adjust on NPM?

@benlesh
Copy link
Member

benlesh commented Oct 29, 2023

No, we just need to publish 7.x again with the change. It's low-priority, but fixable with a publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants