This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/redd/howurls-work/jhhdizgk4
✅ Preview: https://howurls-work-git-fork-niklas-e-subdomains.redd.now.sh

Hey, @niklas-e! Thank you so much for this contribution! I'll give it a closer look sometime next week. I think we should introduce a fallback to English in case there's no translation for strings. I can do this as a separate pull request that precedes this one.

Yeah, fallback would be great. Didn't actually notice there wasn't one already as I didn't check the localization implementation. I guess I'm too used to have react-i18next or something similar in my projects.

Technically the dot isn't part of the subdomain. We need to tell domains, sub- and TLDs, are separated by dots. I think an additional panel is needed ; hopefully it won't be too hard to see & click on a dot.

I take that back. Following the spirit of previous panels, including the separator is intuitive enough.

I just noticed this is still open. Is there some prerequisites before this can be merged @kettanaito?

I think we should introduce a fallback to English in case there's no translation for strings. I can do this as a separate pull request that precedes this one.

Have you implemented this?

@niklas-e, no, I haven't got the chance to implement the language fallback. It should be rather straightforward to do. Right now, if the translation is missing, it will show the label IDs:

This isn't nice. I can help translating the new section into as many languages I know but looks like we need some help from the community to provide other translations (such as Chinese, for example).

If you are final with the English description, I can post this pull request around and I'm sure people will help with translations!

I wonder if the dot following the subdomain is considered a part of the subdomain? 🤔 Right now, the way it's highlighted in the UI implies that is is.