Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple does'nt affect children #56

Open
sergiyvergun opened this issue Jan 23, 2020 · 0 comments
Open

Ripple does'nt affect children #56

sergiyvergun opened this issue Jan 23, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@sergiyvergun
Copy link

The problem is that ripple doesn't affect children. How it can be fixed?
If I wrap the parent with another parent and add ripple to it, it doesn't actually work as it has to do.

image

after tap:
image

Parent(
      style: ParentStyle()
        ..background.color(Theme.of(context).accentColor)
        ..borderRadius(all: flashcardSmallBorderRadius)
        ..border(all: 1, color: Colors.grey[100])
        ..elevation(10, color: Colors.grey[400])
        ..animate(100, Curves.bounceIn)
        ..ripple(!isIOS)
        ..margin(
            vertical: flashcardSmallVerticalMargin,
            horizontal: flashcardSmallHorizontalMargin)
        ..padding(
            vertical: flashcardSmallVerticalPadding,
            horizontal: flashcardSmallHorizontalPadding),
      child: Column(
        children: <Widget>[
          flashcard.frontText.isNotEmpty
              ? SmallFlashcardTitle(flashcard.frontText)
              : Container(),
          flashcard.frontImages.isNotEmpty
              ? CustomImage(
                  imagePaths: flashcard.frontImages,
                )
              : Container(),
          Container(
            margin: EdgeInsets.symmetric(vertical: flashcardSmallSidesDistance),
            color: Theme.of(context).dividerColor,
            height: 1,
          ),
          flashcard.backText.isNotEmpty
              ? SmallFlashcardTitle(flashcard.backText)
              : Container(),
          flashcard.backImages.isNotEmpty
              ? CustomImage(
                  imagePaths: flashcard.backImages,
                )
              : Container(),
        ],
      ),
    );
@ReinBentdal ReinBentdal added the bug Something isn't working label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants