Some graphic bugs

[nessor]

Hey guys,

I've found some litte graphic bugs. I'm using windows 10 v1803 and VS2017 Pro.

When you inherit the mainform with the RibbonForm some small black lines appear under the tabs:

All elements are not vertically centered. This causes checkboxes to truncate the text (or have I overlooked a setting?)

-nessor

[tajbender]

@adriancs2: Could you please take a look at this issue? Thanks!

[adriancs2]

I have run a simple test. The black lines did not appear in my case. I'm unable to identify the problem at the moment. You can try to use the nuget version, and try again and see if the problem still exists.

[nessor]

it's weird. I used the source code and compiled the dll myself. It works now.

[scholle]

I or you can reproduce this behavior, when you add some code to the manifest file, to add HiDPI functionality.

Add a manifest file, change

<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">

to

<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3" >

and add at the end

<asmv3:application> <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings"> <dpiAware>true/PM</dpiAware> </asmv3:windowsSettings> </asmv3:application>

This is needed, when you try to use the build in HiDPI functions of .NET 4.7.2 and 4.8.

Scholle

Edit: If you step back to .NET 4.6, everything is OK again

[nessor]

I'm using .NET Framework 4.7.2. The problem occurs when I include the compiled .dll. When embedding the source code into a separate project, everything looks fine.

I didn't edit the manifest file, at leas not consciously . Does the VS adapt it itself?

[adriancs2]

@scholle I see. Thanks for the discovery.

@tajbender Maybe this can be fixed somewhere in the coding. You can try to have a look when you're free. thanks

[adriancs2]

Below is the sample that uses the nuget version, I have tried in both .net 4.7.2 and .net 4.8. It seems ok. I guess that the issue might be caused by older version of the ribbon, and the problem is already fixed in new version of ribbon.
WindowsFormsApp2.zip

[scholle]

For me, it seems to look good now. Even with manifest file.
Thanks

[tajbender]

This is weird; Could someone please take a look, which version caused the problems, and which version did fix them?

However, for version 6, I'm digging into High-DPI issues anyways, but it would be good to know when and how this bug has been fixed, so many many thanks to all of you!

[scholle]

Because you asked for, I did some tests. I took the second Version of WindowsFormsApp2.zip and compiled it -> OK.
I added (as described earlier) a manifest file and compiled -> OK.

Now weird things happen. I then changed the reference to an other Version from the packages folder and it seemed to be OK. I switched back to the latest DLL -> graphics problem.
Now I am not able to get back to a version without bug. I tried my compiled DLL, compiled all new, took different DLLs. Nothings helps. A reboot didn´t help out.

And now the second weird thing. If I delete the manifest file and compile again -> OK
When I now add the manifest file again and rebuild all, everything is OK again.

In every step I cleared the project and rebuilt everything. I can only imagine, that Visual Studio is setting some parameter in the GAC, when you add the manifest file. I don´t have another answer.

Maybe this helps again

[tajbender]

@scholle: This is very strange indeed, I'm relatively new to this project, but I'm pretty sure that at this fragments of the code nothing has been changed in the last weeks, that's why I was wondering and asked how to reproduce this issue...

The next thing is, cause we'll add HiDPI into the next version, I already played around little bit; I had Issues, but not that one 😜

However, thank you so far, I'll leave this issue open as long as the cause for the bugfix hasn't been found 😏

[scholle]

Another bug: the color of the title bar text is wrong. On my Windows, the header text in the ribbon is black, but my Windows is white.

[tajbender]

@scholle: Well, this is not a bug, it's a feature :)

The reason for that is that the colors that are used for rendering are chosen by the OrbStyle and the ColorTheme. They are not chosen by evaluating the default windows colors.

Are did I get you wrong?