Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE 11 support #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

IE 11 support #18

wants to merge 2 commits into from

Conversation

samboylett
Copy link

Resolves #16

Removes use of Object.assign in favour of the second parameter of Object.create. This is supported by IE11.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create#Using_propertiesObject_argument_with_Object.create()

Also added a test for this case.

@manniL
Copy link

manniL commented Feb 13, 2019

@aldarund maybe we can directly apply that one?

@manniL manniL mentioned this pull request Feb 16, 2019
Closed
@aldarund aldarund mentioned this pull request Feb 22, 2019
Merged
@MLDMoritz
Copy link

Ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IE 11 support
3 participants
@samboylett @manniL @MLDMoritz