Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assert more spec-compliant #16

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Make assert more spec-compliant #16

merged 3 commits into from
Mar 4, 2024

Conversation

Richienb
Copy link
Contributor

@Richienb Richienb commented Aug 12, 2021 •
edited

Current polyfill:

console.assert(false)
//=> Uncaught AssertionError [ERR_ASSERTION]: false == true

console.assert(false, 1, 2, 3)
//=> Uncaught AssertionError [ERR_ASSERTION]: 1

Normal behaviour:

console.assert(false)
//=> Assertion failed

console.assert(false, 1, 2, 3)
//=> Assertion failed: 1 2 3

New behaviour:

console.assert(false)
//=> Assertion failed

console.assert(false, 1, 2, 3)
//=> Assertion failed: 1 2 3

Fixes #5
Also fixes Richienb/node-polyfill-webpack-plugin#18

@goto-bus-stop goto-bus-stop self-requested a review August 13, 2021 07:54
@Richienb
Copy link
Contributor Author

Richienb commented Sep 14, 2021 •
edited

// @Raynos @goto-bus-stop

@Raynos
Copy link
Collaborator

Raynos commented Sep 14, 2021

This seems reasonable to me.

@niksy
Copy link

niksy commented Dec 6, 2021

What is the status of this PR? I see that @goto-bus-stop has been requested as reviewer.

@Raynos Raynos merged commit 10e4489 into browserify:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop Awaiting requested review from goto-bus-stop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An attempt to use util ends in a painful circular dependency Fix dependency chain
3 participants
@Richienb @Raynos @niksy