Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Req]: Can we include fs module polyfill to the plugin? #41

Closed
AkshitAggarwal opened this issue May 23, 2023 · 4 comments · Fixed by #45
Closed

[Feature Req]: Can we include fs module polyfill to the plugin? #41

AkshitAggarwal opened this issue May 23, 2023 · 4 comments · Fixed by #45

Comments

@AkshitAggarwal
Copy link

This plugin is super helpful, so far most of the core modules are included as I can see. But I had to include the polyfill for fs module separately. Can we include that in the global plugin itself?

@Richienb
Copy link
Owner

Richienb commented Oct 9, 2023

Which fs polyfill is used?

@afonsojramos
Copy link
Contributor

@Richienb there is no polyfill for fs in the browser, hence #45.

@Richienb
Copy link
Owner

@afonsojramos What's the user experience with using 'fs': false?
Does it necessitate adding a note about it in the readme?

@afonsojramos
Copy link
Contributor

The point of this repo is to facilitate polyfills, and since there is no polyfill for fs, we might as well set it to false to set it as an empty implementation. Even some upgrade guides of webpack v4 to v5 suggest it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants