Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DOM manipulation when replacing HTML elementattributes #377

Open
Ocramius opened this issue Apr 19, 2024 · 2 comments
Open

Use DOM manipulation when replacing HTML elementattributes #377

Ocramius opened this issue Apr 19, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Ocramius
Copy link
Member

Originally posted by @Ocramius in #376 (comment)

We should look into getting rid of string replacements, and using DOM manipulation for HTML replacements, where possible.

This is NOT a security issue because this tool is intended for use on repository sources, NOT user input.

@Ocramius Ocramius added enhancement New feature or request help wanted Extra attention is needed labels Apr 19, 2024
@Ocramius
Copy link
Member Author

@asgrim
Copy link
Member

asgrim commented Apr 23, 2024

I've started work on this, although it will need a lot more time put into it than initially anticipated, as the resulting HTML is not quite right. Branch with my progress so far is at https://github.com/Roave/DocbookTool/tree/use-dom-manipulation-for-confluence-writer (but note: it is failing, and very much WIP! not ready for PR review yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants