Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): compatible constructor with sequelize #1310

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

lukashroch
Copy link
Collaborator

Makes the model constructor compatible with recent sequelize changes (sequelize/sequelize@f5c06bd)

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #1310 (bf16178) into master (cb478e2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1310   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files         117      117           
  Lines        1123     1123           
  Branches      128      128           
=======================================
  Hits         1068     1068           
  Misses         23       23           
  Partials       32       32           
Impacted Files Coverage Δ
src/model/model/model.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb478e2...bf16178. Read the comment docs.

Copy link
Contributor

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@theoludwig theoludwig merged commit 4f03520 into sequelize:master Jun 14, 2022
@lukashroch lukashroch deleted the constructor-fix branch October 14, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants