Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to TypeScript 4.8 #1453

Merged
merged 2 commits into from
Oct 12, 2022
Merged

fix: update to TypeScript 4.8 #1453

merged 2 commits into from
Oct 12, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Oct 12, 2022

All I did was adding extends {} whenever promted by tsc. I also ran npm audit fix which updated vm2

Fixes #1441
Closes #1439

@WikiRik WikiRik requested review from sdepold and ephys October 12, 2022 13:57
Copy link

@TmarcAHX TmarcAHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's redundant or not but I needed to add an ' = any' in as well.

Ex.
extends {} = any

@WikiRik WikiRik merged commit 5ddfa61 into master Oct 12, 2022
@WikiRik WikiRik deleted the WikiRik/ts-4.8 branch October 12, 2022 22:54
@WikiRik
Copy link
Member Author

WikiRik commented Oct 12, 2022

@lukashroch would you be so kind to publish a new release? (possibly after merging some additional dependabot PRs)

@lukashroch
Copy link
Collaborator

@WikiRik sure, no problem. I think I have to go through PR anyway and then create release on github to trigger the release on npm.

I'll try to merge some dependabot PRs too but current setup is bit tedious. Might be worth to switch to renovate with some grouping patterns or automerge at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler error with typescript@4.8.4, sequelize@6.23.2, sequelize-typescript@2.1.3
3 participants