Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation is not used #2048

Open
2 tasks done
CvH opened this issue May 25, 2021 · 12 comments · May be fixed by #2856
Open
2 tasks done

Translation is not used #2048

CvH opened this issue May 25, 2021 · 12 comments · May be fixed by #2856

Comments

@CvH
Copy link

CvH commented May 25, 2021

My Setup

  • Operating System: Win10
  • App Version: 3.2.2
  • Installation type: rocketchat-setup-3.2.2.exe
  • I have tested with the latest version
  • I can simulate the issue easily

Description

The Interface translation is not working.
I have german at the OS and german at Rocket.Chat - the Electron Interface stays english all the time.
The Shortcuts are translated for some reason.
image

Current Behavior

The Electron App Interface is in english.

Expected Behavior

The Electron App Interface should be the same as the OS.
@CvH
Copy link
Author

CvH commented Aug 26, 2021

problem still exist at 3.4.0

@jeanfbrito
Copy link
Collaborator

Please test if the problem persists with our latest release. I will be closing the issue but if there is any problem yet, we will open it again.

@CvH
Copy link
Author

CvH commented Aug 5, 2022

image
this is 3.8.7 at windows, still the same problem
basically translations are completly broken even they exist at the repository

for example "Server list" from the screenshot https://github.com/RocketChat/Rocket.Chat.Electron/blob/master/src/i18n/de-DE.i18n.json#L113

@jeanfbrito jeanfbrito reopened this Aug 5, 2022
@jeanfbrito
Copy link
Collaborator

@CvH thanks for replying. I will take a look at what is happening.

@CvH
Copy link
Author

CvH commented Nov 15, 2022

Version 3.8.13, same problem.

@jeanfbrito
Copy link
Collaborator

Version 3.8.13, same problem.

This was to be fixed on the 3.8.13. The translations was lacking some items.
Do you have this problem in other computers or just this one?

@CvH
Copy link
Author

CvH commented Nov 16, 2022 •
edited

It happens at two different pc with completely different setup (Win11) (1x domain, 1x home pc) with the identical problem.
Removed RC + Appdata and reinstalled it again. Same problem at latest RC Client.

image

@CvH
Copy link
Author

CvH commented Jan 2, 2023

Same problem with 3.8.15

@CvH
Copy link
Author

CvH commented Mar 17, 2023

Same problem with 3.8.17

@CvH
Copy link
Author

CvH commented Feb 23, 2024

nearly 2 years later, same general problem still exist at the latest 3.9.14 :(

image

@jeanfbrito
Copy link
Collaborator

nearly 2 years later, same general problem still exist at the latest 3.9.14 :(

image

Thank you for showing it, I have found the fix, and will be on the next release.

@jeanfbrito jeanfbrito linked a pull request Feb 23, 2024 that will close this issue
Open
@CvH
Copy link
Author

CvH commented Feb 23, 2024

great 👍 I test as soon there is a build available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: System locale not working in some languages RocketChat/Rocket.Chat.Electron
2 participants
@jeanfbrito @CvH