-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple spaces after IFDEF is causing defect #269
Comments
I fixed this by changing the before mentioned method as follows:
Only the first added line is in fact necessary to make System.pas being parsed again but I added the second one to see if that fixes any trailing spaces. However there are more defects like this. For example following code still fails because of the implementation of TmwBasePasLex.EvaluateConditionalExpression.
I think this will also fail because of tabs which is why I am not proposing some pull request for this because my fixes are just incomplete. |
Why not just do:
Where |
Simple, because IFDEF cannot span multiple lines. I mentioned tabs because I noticed but there are also not handled in some other places where they should be valid so I would not address that one in the context of this particular issue. |
@RomanYankovsky it look like Resolved. Maybe time to close the issue? :-) |
Following code is a simplified test case for this defect - originally found when trying to parse System.pas from Delphi 10.2
I traced it down to TmwBasePasLex.GetDirectiveParam returning the string with a leading space character in this case.
The text was updated successfully, but these errors were encountered: