Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the end_line and end_col of a multi-line comment? #294

Open
PeterPanino opened this issue Dec 12, 2019 · 3 comments
Open

Get the end_line and end_col of a multi-line comment? #294

PeterPanino opened this issue Dec 12, 2019 · 3 comments

Comments

@PeterPanino
Copy link

PeterPanino commented Dec 12, 2019

While the uses node:
<USES begin_line="7" begin_col="1" end_line="14" end_col="1">
... as a multiline element has the attributes begin_line, begin_col, end_line, end_col,
the Comments-node object has only the members line and col. Although a comment can be multiple lines.

So how can I determine the end_line and end_col of a multi-line comment?

@RomanYankovsky
Copy link
Owner

But can't you calculate this from comment text?

@PeterPanino
Copy link
Author

Yes, but this would be a kind of guessing. Having an EXPLICIT syntax tree information about the end_line and end_col of a multi-line comment would be better.

@bogdanpolak
Copy link

@RomanYankovsky I think that this yet another to decide which way to go: close (out of scope) or triage it as a new feature: great idea is to assign labels: enhancement and help wanted to highlight your decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants