Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker - Warning: findDOMNode is deprecated in StrictMode #3528

Open
thyhjwb6 opened this issue Nov 25, 2022 · 5 comments
Open

DatePicker - Warning: findDOMNode is deprecated in StrictMode #3528

thyhjwb6 opened this issue Nov 25, 2022 · 5 comments
Labels
Size: Small Assessed as small task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
Tactical Board

Comments

@thyhjwb6
Copy link
Collaborator

Steps to reproduce

  1. Create a new application using the CRA template
  2. Add DatePicker inside React.StrictMode
  3. Start application
  4. Open DatePicker sheet and view the console

Screenshot

Screenshot 2022-11-25 at 16 05 05
@thyhjwb6 thyhjwb6 added Status: Awaiting triage Issues not yet triaged by the Design System cra-template-royalnavy Type: Bug Inconsistencies or issues which have caused a problem for users or implementors labels Nov 25, 2022
@jpveooys
Copy link
Contributor

jpveooys commented Nov 25, 2022 •
edited

Hi @thyhjwb6 👋

There was a fix for this in version 9.0.0 or newer of focus-trap-react: focus-trap/focus-trap-react#77

However, we're unable to update at the moment as it would break support for older browsers (which would be a breaking change).

@jpveooys jpveooys added Status: Blocked Unable to progress currently due to internal/external blocker Size: Small Assessed as small task and removed Status: Awaiting triage Issues not yet triaged by the Design System cra-template-royalnavy labels Nov 25, 2022
@ahwcikxz ahwcikxz added this to Candidates for Ready in Tactical Board Nov 25, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Jan 30, 2023
@oliverrees
Copy link

+1 for this issue!

@github-actions github-actions bot removed the Status: Stale Issue with no activity for the past 60 days label Nov 20, 2023
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been open for 60 days with no activity

@github-actions github-actions bot added the Status: Stale Issue with no activity for the past 60 days label Jan 22, 2024
@markhigham markhigham removed Status: Blocked Unable to progress currently due to internal/external blocker Status: Stale Issue with no activity for the past 60 days labels Apr 5, 2024
@markhigham
Copy link
Collaborator

Revisiting this as legacy browser support requirements have changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Size: Small Assessed as small task Type: Bug Inconsistencies or issues which have caused a problem for users or implementors
Projects
Tactical Board
Candidates for Ready
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markhigham @oliverrees @thyhjwb6 @jpveooys