Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window not staying in place when changing images #4

Open
Ruben2776 opened this issue May 15, 2020 · 5 comments
Open

Fix window not staying in place when changing images #4

Ruben2776 opened this issue May 15, 2020 · 5 comments
Labels
help wanted PR Welcome Pull requests are welcome

Comments

@Ruben2776
Copy link
Owner

Ruben2776 commented May 15, 2020

Currently the window is forced to center, to avoid gradually losing center position.

This would be nice to fix, so that you could drag the application around and change images, while still having it the window resizing.

Like how JPEGView works (which this application is heavily inspired by).

Resizing is done by a window sizing override

protected override void OnRenderSizeChanged(SizeChangedInfo sizeInfo)

and a function to scale the image

internal static void FitImage(double width, double height)

@Ruben2776 Ruben2776 added this to To do in Planned features Sep 12, 2021
@Ruben2776 Ruben2776 moved this from To do to In progress in Planned features Sep 12, 2021
@Ruben2776 Ruben2776 moved this from In progress to Review in progress in Planned features Sep 12, 2021
@Ruben2776 Ruben2776 removed this from Review in progress in Planned features Sep 12, 2021
@Ruben2776 Ruben2776 added the PR Welcome Pull requests are welcome label Nov 7, 2021
@mardulas
Copy link

mardulas commented Mar 8, 2023

The setting "keep window centered" does not do anything, I suppose this is why?

@mardulas
Copy link

mardulas commented Mar 8, 2023

Actually it does something, it forces the window a bit up and left (from the center) when it's on. So on means it's not centered and off means it's centered. Ahem...

@mardulas
Copy link

mardulas commented Mar 8, 2023

At least when I turn off resize window and keep centered, then it keeps the window position. Which is ok.

@arthur1976
Copy link

在最新版本 没人发现 将图片设置成桌面背景时软件就卡死 退出吗?

@Ruben2776
Copy link
Owner Author

Ruben2776 commented Mar 24, 2023

在最新版本 没人发现 将图片设置成桌面背景时软件就卡死 退出吗?

My apologies. The wallpaper function has been fixed in the latest version. I know it's a bit slow when effects are applied, I might improve it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted PR Welcome Pull requests are welcome
Projects
None yet
Development

No branches or pull requests

3 participants