Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OneTap for Google login #3

Open
dieptang opened this issue Feb 24, 2023 · 2 comments
Open

OneTap for Google login #3

dieptang opened this issue Feb 24, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@dieptang
Copy link

Hello,

Inresresting plugin!
Is it support One Single Click for login Google?

Currently, when click login, it's redirect to the google page. It should be popup windows instead of that is more flexible.

Regards,

@ve3
Copy link
Contributor

ve3 commented Feb 24, 2023

Google One tap is not OAuth (as I know). So, sorry but it doesn't support One tap.

I use redirect instead of popup because 2 reasons. 1. I follow the Google document and they use redirect. 2. It seems that a lot of users have popup blocker. So, that will not work on many users.

Another reason I just searched and found is on these topic (1) (2) that is interesting.

@dieptang
Copy link
Author

Yes. You're right.

As you see the overview from Google. It's actually opening on the popup. Don't worry about the issue with the blocking popup. No body blocking google :D

This issue should be feature request.

@ve3 ve3 added the enhancement New feature or request label Feb 24, 2023
@dieptang dieptang changed the title Is is support Google dialog one click? OneTap for Google login Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants