-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP incoming requests not showing #63
Comments
That's interesting, I would expect it to happen for attach() or monitor() (since attach just calls monitor). Perhap the difference is between monitor's two modes, the "create an internal express/http Server" mode, and the "replace an http Server's even listeners" mode? Attach only uses the latter, because it attaches to a pre-existing http Server, it doesn't create its own, but the example code uses the "open a second server on a second port" mode. |
Also, appmetrics is generally expected to be the first module required, which makes it awkward when its required internally by appmetrics-dash, and appmetrics-dash allows an http server to be injected, which means it supports being called to late, doesn't it? |
This is because of how the probes work (they hook into 'require' calls). With monitor we call @tobespc the docs update needs to also cover calling monitor and passing in a server |
Fixed by #72 |
this is for RuntimeTools/appmetrics#408
only happens when using .attach() method. Seems we need to require appmetics first then pass it into the constructor for the dashboard
var appmetrics = require('appmetrics')
var dash = require('appmetrics-dash')
var express = require("express");
var app = express();
dash.attach({appmetrics:appmetrics});
docs change required
The text was updated successfully, but these errors were encountered: