Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetry in default features: only p384 has ecdh by default #1047

Open
hko-s opened this issue May 13, 2024 · 2 comments
Open

Asymmetry in default features: only p384 has ecdh by default #1047

hko-s opened this issue May 13, 2024 · 2 comments

Comments

@hko-s
Copy link

hko-s commented May 13, 2024

The p384 crate differs from the other curves in that it enables the ecdh feature by default in Cargo.toml.

This is obviously not a huge deal, but I wonder if it would be good to remove it from the default features, for symmetry?

@tarcieri
Copy link
Member

Yes, it is a bit weird it's inconsistent.

Alternatively we could add ecdh to the default features of the other crates. The only drawback is the added hkdf dependency.

@hko-s
Copy link
Author

hko-s commented May 13, 2024

I'm afraid I have no useful opinion on which way to resolve this, I just stumbled over the difference 🤷

Personally, I'm happy either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants