Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown Link Check Job Fails #540

Closed
CMNatic opened this issue Mar 16, 2024 · 0 comments · Fixed by #542
Closed

Markdown Link Check Job Fails #540

CMNatic opened this issue Mar 16, 2024 · 0 comments · Fixed by #542
Assignees

Comments

@CMNatic
Copy link
Contributor

CMNatic commented Mar 16, 2024

Describe the bug
The markdown-link-check job fails because it is false-flagging the following URLS as 404. For example: https://github.com/RustScan/RustScan/actions/runs/8303741977/job/22728380037

[✖] https://github.com/RustScan/RustScan/workflows/Continuous%20integration/badge.svg?branch=master → Status: 404
[✖] https://crates.io/crates/rustscan/ → Status: 404
[✖] https://bees.substack.com/p/making-hacking-accessible

This seems to be a known thing:

  1. Getting 404 for links that certainly work gaurav-nelson/github-action-markdown-link-check#102
  2. 403 for github.com because it blocks requests without --compressed curl flag tcort/markdown-link-check#201 (comment)
  3. some specific links are marked as dead gaurav-nelson/github-action-markdown-link-check#169

Intended Solution

  1. Create a mlc_config.json file in the .github/workflows folder
  2. As per tcort, we can add these URLs to be ignored. It's not ideal, but this is a workaround that has been suggested in numerous issues.

The alternative is reconfiguring the workflow to continue-on-error, which is probably the worst of the two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant