Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use return type single instead of observable #166

Closed
wants to merge 1 commit into from
Closed

use return type single instead of observable #166

wants to merge 1 commit into from

Conversation

geonu1109
Copy link
Member

No description provided.

@geonu1109 geonu1109 changed the title use return type single instead of observable #165 use return type single instead of observable Mar 2, 2020
@rxswiftcommunity
Copy link

Warnings
⚠️

It looks like code was changed without adding anything to the Changelog. If this is a trivial PR that doesn't need a changelog, add #trivial to the PR title or body.

Generated by 🚫 dangerJS

@geonu1109 geonu1109 linked an issue Mar 2, 2020 that may be closed by this pull request
use return type single instead of observable #165
Open
@rynecheow
Copy link
Member

Hi @geonu1109, thanks for your PR! As this PR consist of breaking change, we are going to park this for 6.0.0 release. We'll temporarily hold this PR till we are ready to accept this change.

@rynecheow rynecheow added enhancement breaking Breaking changes introduced labels May 25, 2020
@rynecheow rynecheow marked this pull request as draft May 25, 2020 05:38
@rynecheow rynecheow added this to To do in RxAlamofire 6.0.0 May 26, 2020
@rynecheow rynecheow changed the base branch from master to release/6.0.0 June 7, 2020 03:48
@rynecheow rynecheow changed the base branch from release/6.0.0 to master June 7, 2020 03:58
@rynecheow rynecheow changed the base branch from master to feature/6.0.0 June 7, 2020 03:58
@rynecheow rynecheow marked this pull request as ready for review June 7, 2020 03:58
@rynecheow rynecheow closed this Jun 22, 2020
RxAlamofire 6.0.0 automation moved this from To do to Done Jun 22, 2020
@vburojevic
Copy link

Hi @rynecheow, will this eventually be introduced in RxAlamofire v6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Breaking changes introduced enhancement
Projects
RxAlamofire 6.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use return type single instead of observable
4 participants
@geonu1109 @rynecheow @vburojevic @GeonuDaou