Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docker image size optimization and tests #29

Open
jerome-benoit opened this issue Nov 4, 2022 · 0 comments
Open

Missing docker image size optimization and tests #29

jerome-benoit opened this issue Nov 4, 2022 · 0 comments
Assignees

Comments

@jerome-benoit
Copy link

jerome-benoit commented Nov 4, 2022

  • tools not needing to be shipped in the image like gnupg are not cleaned up
  • changes to image are put in different layers of the multistage build
  • several Dockerfiles where only one is needed
  • no architecture platform support check
  • no smoke test

You can find a properly and optimized Dockerfile here: https://github.tools.sap/E-Mobility/mbt-docker/blob/main/Dockerfile with a section to install SAP machine with image size optimization.
And a PR showing how to reuse the same Dockerfile to generate images for different version: https://github.tools.sap/E-Mobility/mbt-docker/pull/8

@chalstrick chalstrick self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants