Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectHeader footnote text is cut when user changes dynamic text size #419

Open
dzmitry-antonenka-sap opened this issue Apr 20, 2022 · 1 comment
Assignees

Comments

@dzmitry-antonenka-sap
Copy link

Describe the bug
ObjectHeader footnote text is cut when user changes dynamic text size

To Reproduce

  1. For Examples.xcodeproj replace content of the ContentView.swift with following code:
    `
    import FioriCharts
    import SwiftUI
    import FioriCharts
    import FioriSwiftUICore
    import FioriCharts
    import FioriSwiftUICore
    import SwiftUI
    struct ContentView: View {
    var body: some View {
    BrokenObjectHeader()
    }
    }

struct BrokenObjectHeader: View {
var body: some View {
NavigationView {
NavigationLink("Open details") {
ScrollView {
VStack(spacing: 30) {
ObjectHeader {
Text("Some title text explaining something")
.font(.fiori(forTextStyle: .title3))
.foregroundColor(.preferredColor(.primaryLabel))
.fontWeight(.black)
} subtitle: {
Text("Some author name")
.font(.fiori(forTextStyle: .body))
.foregroundColor(.preferredColor(.secondaryLabel))
.fontWeight(.regular)
} footnote: {
Text("2 days ago")
.font(.fiori(forTextStyle: .subheadline))
.foregroundColor(.preferredColor(.tertiaryLabel))
.fontWeight(.regular)
}
}
}
}
}
}
}
`

  1. Launch the app
  2. Press "Open details" button and increase dynamic text size to extra extra large size using environment overrides
  3. Press "Back"
  4. Press "Open details" and decrease dynamic text size to extra extra small size using environment overrides
  5. Observe footnote clipped
clipped-text-issue.mov

Expected behavior
The text should be fully rendered with matching dynamic size

Screenshots
Simulator Screen Shot - iPhone SE (2nd generation) - 2022-04-20 at 19 38 06

Mobile (please complete the following information):

  • Device: iPhone SE - 2nd generation (Simulator)
  • OS: iOS 15.4
  • Swift Package Product: FioriSwiftUICore
  • Swift Package Version: 2.1.0, main branch, commit 0786a13
  • Xcode Version: Version 13.3 (13E113), toolchain Xcode 13.3
  • FioriSwiftUI / cloud-sdk-ios-fiori 2.1.0
@billzhou0223
Copy link
Contributor

@shengxu7 Can you take a look at this issue when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants