Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript invalid with TS compilerOptions "noImplicitOverride": true #4576

Open
GoWale opened this issue Mar 20, 2024 · 1 comment
Open

Comments

@GoWale
Copy link

GoWale commented Mar 20, 2024

Describe the bug
Generated TypeScript files are not valid when setting "noImplicitOverride": true in tsconfig.json

To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/GoWale/issue-cloud_sdk-odatav4.git
npm i

  1. Set up ... start the cap server via npm run start
  2. Execute ... npm run sdk_gen_client (with the running server providing the EDMX)
  3. See error now you should see the typescript complains in the console

Expected behavior
generated typescript should support "noImplicitOverride"

Used Versions:

  • node version v20.10.0
  • npm version 10.2.5
  • SAP Cloud SDK version you used as dependency
    "@sap-cloud-sdk/generator": "^3.12.1",

Impact / Priority

low / medium: we can add the override by hand or remove the typescript validation

Affected development phase: Development / CI/CD

@GoWale GoWale added the bug Something isn't working label Mar 20, 2024
@deekshas8 deekshas8 removed the bug Something isn't working label Mar 21, 2024
@deekshas8
Copy link
Contributor

Hi @GoWale,
This config setting is currently not supported. I'll create a ticket to update our client generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants