Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - CPE does not start UI Adaptation for ui5 versions lower than 1.120 for Adaptation Projects #1929

Closed
3 tasks
nikmace opened this issue May 15, 2024 · 0 comments · Fixed by #1931
Closed
3 tasks
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client

Comments

@nikmace
Copy link
Contributor

nikmace commented May 15, 2024

Related Feature

Feature request: #1874

Description

CPE breaks for Adaptation Projects with the ui5 version lower than 1.120.

This import is causing the error in packages/preview-middleware-client/src/adp/init.ts:

import UI5ElementRegistry from 'sap/ui/core/ElementRegistry';

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start and ADP with ui5 version 1.108.31 for example
  2. Open dev tools and look at the console
  3. See the error (screenshot below)

Expected results

UI Adaptation is started by RTA

Actual results

RTA does not start.

Screenshots

If applicable, add screenshots to help explain the problem.

Screenshot 2024-05-15 at 13 48 05 Screenshot 2024-05-15 at 13 49 30

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

@nikmace nikmace added bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client labels May 15, 2024
@nikmace nikmace changed the title BUG - CPE does not start UI Adaptation for ui5 versions lower than 1.121.1 for Adaptation Projects BUG - CPE does not start UI Adaptation for ui5 versions lower than 1.120 for Adaptation Projects May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
1 participant