-
Notifications
You must be signed in to change notification settings - Fork 371
/
CODEOWNERS
Validating CODEOWNERS rules...
83 lines (70 loc) · 3.98 KB
/
CODEOWNERS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
# ==================================================================================
# ==================================================================================
# Spartacus CODEOWNERS
# ==================================================================================
# ==================================================================================
#
# Configuration of code ownership and review approvals for the spartacus repo.
#
# More info: https://help.github.com/articles/about-codeowners/
#
# ================================================
# General rules / philosophy
# ================================================
#
# - we trust that people do the right thing and not approve changes they don't feel confident reviewing
# - we use github teams so that we funnel code reviews to the most appropriate reviewer, this is why the team structure is fine-grained
# - we enforce that only approved PRs get merged to ensure that unreviewed code doesn't get accidentally merged
# - we delegate approval rights as much as possible so that we can scale better
# - each group must have at least one person, but several people are preferable to avoid a single point of failure issues
# - a small number of file groups may have very limited number of reviewers because incorrect changes to the files they guard would have serious consequences (e.g. security, public api)
#
# Configuration nuances:
#
# - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
# - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
# - Each codeowners team must have write access to the repo, otherwise their reviews won't count.
# ================================================
# All the files in the repo.
# ================================================
* @SAP/spartacus-codeowners
# ================================================
# This code owners file
# ================================================
/.github/CODEOWNERS @SAP/spartacus-admins
# ================================================
# Folders where anyone with write access to the repo can approve Pull Requests
# ================================================
/docs/
/projects/storefrontapp-e2e-cypress/
# @SAP/spartacus-codeowners needs to be repeated in each subsequent rules
# to remain owner of all the sources in the repo.
# ================================================
# ASM
# ================================================
/feature-libs/asm/ @SAP/spartacus-codeowners @SAP/spartacus-holidays
# ================================================
# User domain
# ================================================
/feature-libs/user/ @SAP/spartacus-codeowners @SAP/spartacus-holidays
/projects/storefrontlib/cms-components/myaccount/ @SAP/spartacus-codeowners @SAP/spartacus-holidays
# ================================================
# Product Configurator (VC and CPQ) integration
# ================================================
/feature-libs/product-configurator/ @SAP/spartacus-codeowners @SAP/spartacus-CPQ
# ================================================
# Quotes
# ================================================
/feature-libs/quote/ @SAP/spartacus-codeowners @SAP/spartacus-CPQ
# ================================================
# Intelligent services (ISS)
# ================================================
/integration-libs/cds/ @SAP/spartacus-codeowners @SAP/spartacus-CDS
# ================================================
# (CDC)
# ================================================
/integration-libs/cdc/ @SAP/spartacus-codeowners @SAP/spartacus-CDC
# ================================================
# BOPIS
# ================================================
/feature-libs/pickup-in-store/ @SAP/spartacus-codeowners @SAP/spartacus-colossus