Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.make-container-max-widths() no longer available as of bootstrap 4.5.1 #8444

Closed
nderise opened this issue Aug 5, 2020 · 3 comments
Closed
Labels
bug Something isn't working from-community
Milestone

Comments

@nderise
Copy link

nderise commented Aug 5, 2020

Describe the bug
With the 4.5.1 version of bootstrap, yarn start fails when installing Spartacus using schematics with the following error
ERROR in ./src/styles.scss (./node_modules/css-loader/dist/cjs.js??ref--13-1!./node_modules/postcss-loader/src??embedded!./node_modules/sass-loader/dist/cjs.js??ref--13-3!./src/styles.scss) Module build failed (from ./node_modules/sass-loader/dist/cjs.js): SassError: Undefined mixin. ╷ 7 │ @include make-container-max-widths(); │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

To Reproduce
Steps to reproduce the behavior:
1.$ ng new mystore --style=scss
2.$ cd mystore
3.$ ng add @spartacus/schematics
4.$ yarn start

Expected behavior
Server starts, listening on port 4200

Desktop (please complete the following information):

  • OS: darwin x64
  • Browser : cli
  • Version 2.0.6

Additional context
One of the commits (#30969) in the 4.5.1 bootstrap release, removes the mixin mentioned above which is called explicitly in container.scss within @spartacus/styles.
Specifically requesting 4.5.0 in package.json circumvents the problem for now

@Xymmer Xymmer added bug Something isn't working from-community labels Aug 6, 2020
@Xymmer
Copy link
Contributor

Xymmer commented Aug 11, 2020

related to #8498?

@nderise
Copy link
Author

nderise commented Aug 11, 2020

Yes. Same issue. Bootstrap has fixed it and doesn't plan to remove this mixin for version 4. I think this should probably be closed unless some action needs to be taken to document that specifically version 4.5.1 of bootstrap will cause build errors in Spartacus

@Xymmer
Copy link
Contributor

Xymmer commented Aug 12, 2020

thanks! W recommend 4.2.1 (not 4.5.1) and it looks like they fixed this in 4.5.2. we're reverting our hard-coding of 4.2.1 for future releases, and we also will remove our use of deprecation function (see #8498).

@Xymmer Xymmer closed this as completed Aug 12, 2020
@Xymmer Xymmer added this to the before-5.0 milestone Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working from-community
Projects
None yet
Development

No branches or pull requests

2 participants